Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(version-support-status): remove outdated info, resolve inconsistencies #16684

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

mgol
Copy link
Member

@mgol mgol commented Sep 5, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Docs update.

What is the current behavior? (You can also link to an open issue here)

https://docs.angularjs.org/misc/version-support-status is outdated, it talks about August 2018 in future tense.

What is the new behavior (if this is a feature change)?

Outdated info is removed, inconsistencies (e.g. around 1.2 support) are resolved.

Does this PR introduce a breaking change?

No.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

@mgol
Copy link
Member Author

mgol commented Sep 5, 2018

Preview of the page after applying my PR:
screen shot 2018-09-05 at 16 13 24

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight English style nit.

@@ -7,26 +7,9 @@
This page describes the support status of the significant versions of AngularJS.

<div class="alert alert-info">
AngularJS is planning one more significant release, version 1.7, and on July 1, 2018 it will enter a 3 year Long Term Support period.
On July 1, 2018 AngularJS has entered a 3 year Long Term Support period.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that AngularJS entered feels more natural. And below.

@mgol mgol force-pushed the version-support-status branch from b0dfb2b to cf3caac Compare September 5, 2018 15:40
@mgol mgol merged commit c42cadd into angular:master Sep 6, 2018
@mgol mgol deleted the version-support-status branch September 6, 2018 08:11
mgol added a commit to mgol/angular.js that referenced this pull request Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants